Scripts/Gundrak: Properly handle wipes on Drakkari Colossus encounter #30462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
not perfect but far better than current status. |
…ter wiping against the elemental
CraftedRO
approved these changes
Mar 4, 2025
Shauren
reviewed
Mar 8, 2025
| if (isFrozen) | ||
| return; | ||
|
|
||
| DoZoneInCombat(); |
Member
There was a problem hiding this comment.
What is this supposed to do? Why are you forcing combat with zone on evade (!) when not frozen during elemental phase?
Contributor
Author
There was a problem hiding this comment.
Very rarely while testing, I had a case that I couldn't really reproduce consistently where the boss would reset upon unfreezing instead of re-engaging player(s), that's why I moved it there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Rework encounter evade logic so that
Issues addressed:
Closes #27811
Tests performed:
builds; tested and working in-game