Scripts/StormwindCity: Implement quest "The King's Command" (29547) #30459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meji46
changed the title
meji46
changed the title
mdX7
approved these changes
Nov 23, 2024
Nyr97
reviewed
Nov 24, 2024
| bool Validate(SpellInfo const* /*spellInfo*/) override | ||
| { | ||
| return ValidateSpellInfo({ | ||
| StormwindCity::Spells::FadeToBlack |
Contributor
There was a problem hiding this comment.
maybe setting using namespace StormwindCity to reduce verbose? it should improve readability
Member
Author
There was a problem hiding this comment.
But I would need to set it to every function that uses any of these variables. The other option is to add constexpr variables to the class
aquadeus
pushed a commit
to aquadeus/TrinityCore
that referenced
this pull request
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Issues addressed:
None
Tests performed:
Builds, tested in-game
Known issues and TODO list: (add/remove lines as needed)
None