Spells/Scripts: Implement Leech Stat and SPELL_AURA_MOD_LEECH #30385
+70
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyr97
reviewed
Oct 30, 2024
|
|
||
| ApplyPct(amount, tmpMod); | ||
|
|
||
| HealInfo healInfo(this, this, amount, leechSpell, leechSpell->GetSchoolMask()); |
There was a problem hiding this comment.
Does this take into account that only effective healing should leech?
There was a problem hiding this comment.
where it says is only effective heal?
There was a problem hiding this comment.
Because Leech only works on healing if it's effective healing, otherwise I can endlessly heal a target and get Leech value from it, which makes no sense:
If I were to heal a target that has 100k hp max., but the target is missing 20k (they're at 80k), and my healing spell is bound to heal 30k, that means I will only Leech from 20k, which is the effective healing of my cast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Tests performed:
Tested in-game