-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Scripts/Spells: Implement first aid related anti-venom item spells #30289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.3.5
Are you sure you want to change the base?
Conversation
|
The question now is, if we want to go with the original balance of the game or if we really want to include classic changes |
|
if it's wotlk classic it must target wotlk classic branch, oh wait :P |
|
Comments say its already nerfed in 3.1.1 (the old wotlk, not classic) and the script should be checking level of the caster of each poison aura |
|
Updated. Can quickly be tested engaging any hostile target and using .cast back 744 and .cast back 11918 or any other poison spells |
I don't think that's true though? This mentions it not working against casters of level below 60. From here
I think the source is clearly the anti-venom user, and the target is the player targetted by that anti-venom. |
|
And to me "source" is poison source - clearly wording is ambiguous (and its a user comment, not some official blz statement) |
|
Well, if the source is the poison source, the source target is still the player getting poisoned, which while not being an official statement, would line up with the guy saying it doesn't work in silithus against mobs under maxLevel. |
|
Conflicting files |
|
Logically it makes sense that the change to the poison level would have been to use the poison's caster level as a drop-in change to the mechanic. It doesn't make any logical sense that you could heal yourself of high level poisons by the account of yourself being low level, and in turn that you couldn't heal yourself from low level poisons because you're higher level. That being said, it's certainly possible that Blizz made a programming/logic error back in the day and checked against the level of the caster of the anti-venom spell, i.e. yourself, instead of the caster of the poison aura, i.e. the enemy that poisoned you, and it being unclear whether that error was fixed before/during the final 3.3.5 release. Presumably nobody checked during WOTLK Classic how it worked there? (not that it's a 100% authority on 3.3.5 blizzlike behaviour being a backported newer engine) My opinion is that due to 100% authoritative answer from 3.3.5 era is impossible to acquire unless someone finds some old video or has old sniffs of this particular mechanic, the most sense would be to implement it how it's logical, that the poison's caster level should be what determines whether the poison can be cured, not your own level. |
Changes proposed:
Makes the following first aid related items work:
Note that WotlK era introduced a hard nerf to the anti-venom items, making them take in account the target's max level instead of the poison spell level, so players couldn't abuse the items to bypass higher level poison mechanics anymore. A conversation regarding this nerf and how the items behaved on higher level targets can be seen here. This is reflected in the spell script.
While the PR targets 3.3.5, if someone seeing this takes this code to the master branch, the scriptname should also be assigned to the spell ids 172368 and 307165, from future expansions.
Issues addressed:
Closes #21518
Tests performed:
Builds & works ingame. Tested against the example in #21518 with one and multiple poison effects present.