Skip to content

Core/GameObject: Activated world chests will now despawn after 5 minutes #30269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Feb 16, 2025
Merged

Core/GameObject: Activated world chests will now despawn after 5 minutes #30269

merged 16 commits into from
Feb 16, 2025

Conversation

CraftedRO
Copy link
Contributor

@CraftedRO CraftedRO commented Sep 27, 2024 •
edited
Loading

Changes proposed:

Issues addressed:

Closes # None

Tests performed:

Does it build, tested in-game as can be seen below:
https://youtu.be/oCFlefTgCKE

Known issues and TODO list: (add/remove lines as needed)

  • [ None. ]

@CraftedRO @kaytotes
Update GameObject.cpp
8aa88c8 
Co-Authored-By: Kaytotes <[email protected]>
Ovahlord
Ovahlord reviewed Sep 27, 2024
View reviewed changes
@kaytotes
Copy link
Contributor

Thanks for porting this upstream for me :)

@CraftedRO
Copy link
Contributor Author

well I hope you don't mind since I didn't asked for permission but woud be great to see more of your fixes merged here.

@kaytotes
Copy link
Contributor

well I hope you don't mind since I didn't asked for permission but woud be great to see more of your fixes merged here.

Never an issue. Our fork is open for a reason I just rarely have time to go through formal review and doubt half our fixes are up to TC standards lol

Ovahlord
Ovahlord reviewed Sep 28, 2024
View reviewed changes
@CraftedRO @kaytotes
feedback x2
ef9bcc0 
Co-Authored-By: Kaytotes <[email protected]>
@CraftedRO CraftedRO closed this Oct 13, 2024
@CraftedRO CraftedRO reopened this Nov 20, 2024
@CraftedRO CraftedRO changed the title Core/GameObject: Activated chests will now despawn after 5 minutes Core/GameObject: Activated world chests will now despawn after 5 minutes Nov 21, 2024
@Faq
Copy link
Contributor

Faq commented Jan 20, 2025

If this is a port from other source, I guess it should be mentioned then.

@CraftedRO
Copy link
Contributor Author

If this is a port from other source, I guess it should be mentioned then.

Added but I don't think that was really needed since we already had author consent.

@mdX7
Copy link
Member

mdX7 commented Jan 20, 2025

If this is a port from other source, I guess it should be mentioned then.

Added but I don't think that was really needed since we already had author consent.

Authorship should always be honored, even if consent to use was given. Otherwise ur pretending its your own code

Shauren
Shauren reviewed Feb 2, 2025
View reviewed changes
@Shauren Shauren merged commit de3ba52 into TrinityCore:3.3.5 Feb 16, 2025
5 checks passed
@CraftedRO CraftedRO deleted the gob branch February 16, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shauren Shauren Shauren left review comments

@kaytotes kaytotes kaytotes left review comments

@Ovahlord Ovahlord Ovahlord left review comments

Assignees
No one assigned
Labels
Branch-3.3.5a Feedback-PatchFix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@CraftedRO @kaytotes @Faq @mdX7 @Shauren @Ovahlord @Aokromes