Core/Misc: Implemented spawn tracking #30247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyr97
reviewed
Sep 17, 2024
Member
|
sql/updates/world/master/2024_99_99_98_world.sql needs to be completely recreated. It drops and creates a table and then tries to delete rows from that table just dropped and created. |
Member
|
src/server/game/Entities/Player/Player.cpp |
meji46
force-pushed
the
spawn-tracking
branch
from
5e4eeb2 to
846efc8
Compare
Member
|
How many rows does DELETE stqo
FROM `spawn_tracking_quest_objective` stqo
LEFT JOIN `quest_objectives` qo ON stqo.`QuestObjectiveId`=qo.`ID`
WHERE qo.`ID` IS NULL;delete at the end of the sql update ? Are most of the rows excluded already before ? |
Member
Author
|
mdX7
reviewed
Dec 31, 2024
Member
mdX7
left a comment
mdX7
left a comment
There was a problem hiding this comment.
seems great already. Would be cool to get a command to get info about spawntracking for targeted npcs; but thats for a separate pr imo
|
|
||
| if (unit->IsCreature()) | ||
| if (SpawnTrackingStateData const* spawnTrackingStateData = unit->GetSpawnTrackingStateDataForPlayer(receiver)) | ||
| stateAnimKitId = spawnTrackingStateData->StateAnimKitId.value_or(0); |
Member
There was a problem hiding this comment.
intended to use 0 here instead of default stateAnimKitId?
mdX7
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Issues addressed:
Closes #29705
Tests performed:
Builds, tested in-game, Added example for quest https://www.wowhead.com/quest=55881/purge-the-totems (.quest add 55881)
Known issues and TODO list: (add/remove lines as needed)