Add getter for sf::Texture::m_pixelsFlipped
#3283
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisThrasher
force-pushed
the
getPixelsFlipped
branch
from
20d2cda to
4ca8dd1
Compare
ZXShady
reviewed
Oct 8, 2024
| /// \return `true` if pixels are flipped, otherwise `false` | ||
| /// | ||
| //////////////////////////////////////////////////////////// | ||
| [[nodiscard]] bool getPixelsFlipped() const; |
There was a problem hiding this comment.
the name is confusing, when I read it I thought it returns a pointer to the pixels flipped but no this is just a boolean getter I think an isPixelsFlipped or something else is better name
There was a problem hiding this comment.
isPixelsFlipped or maybe arePixelsFlipped? I agree that a better name probably exists.
There was a problem hiding this comment.
How about:
m_isYFlippedbool isYFlipped()
or something like that?
|
Is there a need / actual use case to expose this? Or are we exposing an implementation detail? |
|
See the linked issue and issue in imgui-sfml |
Completely missed that, my bad. Will take a look at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1770
There is reason to believe that larger rendering changes in SFML 4 will render (pun intended) this API moot and thus it will get removed. Nevertheless I think there is value in providing this feature even if this feature only lives for as long as SFML 3. It's trivial to write, test, and maintain and I see no reason why this would limit any implementation changes we wish to make in the v3 release cycle.