Skip to content

Glue Variables in User_Guide #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 120 commits into from
Feb 26, 2025
Merged

Glue Variables in User_Guide #615

merged 120 commits into from
Feb 26, 2025

Conversation

xjjiang
Copy link
Contributor

@xjjiang xjjiang commented Nov 28, 2024 •
edited
Loading

Summary

Glue variables in user_guide and misc_resources folders.

Related Issues

  • Resolves #

Backwards incompatibilities

None

New Dependencies

None

@xjjiang xjjiang marked this pull request as draft November 28, 2024 01:54
xjjiang and others added 28 commits November 27, 2024 18:12
@xjjiang
update how_to_contribute_docs.md
a57e8c2
@xjjiang
update how_to_contribute_docs.md
202d3e4
@xjjiang
glue variables in docs/user_guide/mass.ipynb
361523f
@xjjiang
add glue in aerodynamics.ipynb
d56e7af
@xjjiang
add glue in aviary_commands.ipynb
5aead60
@xjjiang
minor update
2f081f7
@xjjiang
update docstring
a8f9c8b
@xjjiang
format aviary command options source code
cabf87a
@xjjiang
add glue to aviary_commands.ipynb
61c2389
@xjjiang
Merge branch 'OpenMDAO:main' into glue_user_guide
ff462c0
@xjjiang
Merge branch 'OpenMDAO:main' into glue_user_guide
9073067
@xjjiang
format _setup_level1_parser in methods_for_level1.py
2d16a94
@xjjiang
autopep8
ecc22dc
@xjjiang
minor
1829237
@xjjiang
Merge branch 'OpenMDAO:main' into glue_user_guide
610e082
@xjjiang
Merge branch 'OpenMDAO:main' into glue_user_guide
ff90a0a
@xjjiang
Merge branch 'OpenMDAO:main' into glue_user_guide
b13d7ba
@xjjiang
move aviary hangar to the end of aviary_commands.ipynb because it cau…
4167a08 
…ses problem when I run. Remove a duplicate glue variable --verbosity.
@xjjiang
glue variables in battery_subsystem_example.ipynb
968a62d
@xjjiang
glue variables in drawing_and_running_simple_missions.ipynb
1c37f92
@xjjiang
glue variables in drawing_and_running_simple_missions.ipynb and examp…
439a61d 
…les_of_the_same_mission_at_different_UI_levels.ipynb
@xjjiang
glue variables in external_aero.ipynb
e291aa2
@xjjiang
add glue variables to features_and_functionalities.ipynb
af117c7
@xjjiang
minor update
028f229
@xjjiang
glue variables in FLOPS_based_detailed_takeoff_and_landing.ipynb
f794777
@xjjiang
glue variables in hamilton_standard.ipynb
e779ba0
@xjjiang
glue variables in input_files.ipynb
01cf911
@xjjiang
glue variables in postprocessing_and_visualizing_results.ipynb
0e93159
crecine
crecine approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@crecine crecine left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending Feedback from @jkirk5 on this comment, this looks good to me

@crecine
Copy link
Contributor

crecine commented Feb 7, 2025

Thanks for doing this, I know it is a lot of work, but I think it is really helpful for catching mismatches between our docs and code

@jkirk5
Copy link
Contributor

jkirk5 commented Feb 11, 2025

Pending Feedback from @jkirk5 on this comment, this looks good to me

@crecine I can't actually see which comment you are linking to (doesn't seem to go to any comment in particular), can you directly ping me in the comment in question?

jkirk5
jkirk5 approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@jkirk5 jkirk5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. If you want to update mass.ipynb to have a table that lists both common and class name for different categories as per my comment on that file go ahead, I'm ok with merging without that change if needed.

@xjjiang
Copy link
Contributor Author

xjjiang commented Feb 18, 2025

Approved. If you want to update mass.ipynb to have a table that lists both common and class name for different categories as per my comment on that file go ahead, I'm ok with merging without that change if needed.

Now, I have both common names and class names for different categories.

@jkirk5 jkirk5 added this pull request to the merge queue Feb 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 21, 2025
@jkirk5 jkirk5 added this pull request to the merge queue Feb 26, 2025
Merged via the queue into OpenMDAO:main with commit 22bff30 Feb 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crecine crecine crecine approved these changes

@jkirk5 jkirk5 jkirk5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xjjiang @crecine @jkirk5