Using conda update in case conda create fails #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertmena
requested changes
Nov 29, 2024
| @@ -320,7 +320,7 @@ def installEnvironCmd(name: str, requirementsFn: str, gpu=False): | |||
|
|
|||
| target = name + '.yml' | |||
| commands = [] | |||
| commands.append('conda env create --yes -f %s' % requirementsFn) | |||
| commands.append('conda env create -f %s || conda env update -f %s' % (requirementsFn, requirementsFn)) | |||
There was a problem hiding this comment.
--yes was removed, add
There was a problem hiding this comment.
Not required with this change.
There was a problem hiding this comment.
--yes is not compatible across versions, thats the purpose of this PR
There was a problem hiding this comment.
Ok, I understood you provide two options the first (newers, the second the olders)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using conda update when conda create fails. In this manner, we are able to handle issue #925 without parsing the conda version.