Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/faction applications #1814

Merged
merged 51 commits into from
Mar 2, 2025
Merged

Conversation

dmccoystephenson
Copy link
Member

@dmccoystephenson dmccoystephenson commented Nov 18, 2024

Problem

Players currently lack a formalized system for applying to join factions, which can make faction management disorganized. There is no structured way for faction leaders to review and approve or deny applications, leading to inconsistent processes.

Solution

This PR introduces a faction application system that allows players to apply to join a faction, with faction leaders having the ability to approve or deny applications. Key features include:

  • A structured application process where players can view factions and submit applications.
  • Faction leaders can review, approve, or deny applications.
  • Players can cancel their applications at any time.
  • Automatic cancellation of other pending applications if:
    • A player’s application is approved.
    • A player accepts a faction invitation.
    • A player creates a new faction.
  • New faction permissions to control who can approve or deny applications.
  • Localization support for all added commands.

Testing

  • ✅ Verified that players can successfully submit applications and view pending applications.
  • ✅ Confirmed that faction leaders can review, approve, and deny applications.
  • ✅ Tested that applicants receive a notification upon approval and gain faction membership.
  • ✅ Ensured that players can cancel their applications and reapply as needed.
  • ✅ Verified that all pending applications are automatically canceled under the correct scenarios.
  • ✅ Confirmed no errors on startup and validated functionality in-game.
    (Draft PR for self-review)

@dmccoystephenson dmccoystephenson linked an issue Nov 18, 2024 that may be closed by this pull request
46 tasks
@dmccoystephenson dmccoystephenson added this to the 5.4.0 milestone Nov 18, 2024
@dmccoystephenson dmccoystephenson self-assigned this Nov 18, 2024
Copy link
Member Author

@dmccoystephenson dmccoystephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review

@dmccoystephenson dmccoystephenson removed this from the 5.4.0 milestone Jan 5, 2025
@dmccoystephenson
Copy link
Member Author

dmccoystephenson commented Mar 1, 2025

final TODOs:

  • Add new language strings to all language files
  • Add new commands to output of help command

@dmccoystephenson dmccoystephenson marked this pull request as ready for review March 2, 2025 18:43
Copy link
Member Author

@dmccoystephenson dmccoystephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dmccoystephenson dmccoystephenson merged commit 156dc08 into develop Mar 2, 2025
1 check passed
@dmccoystephenson dmccoystephenson deleted the feature/faction-applications branch March 2, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow players to submit applications to join factions
1 participant