fix Next.js static routes with server actions#6664
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6664 +/- ##
=======================================
Coverage 54.22% 54.23%
=======================================
Files 352 352
Lines 24500 24524 +24
Branches 5069 5073 +4
=======================================
+ Hits 13285 13300 +15
- Misses 10001 10010 +9
Partials 1214 1214 ☔ View full report in Codecov by Sentry. |
leoortizz
changed the title
Member
jamesdaniels
left a comment
jamesdaniels
left a comment
There was a problem hiding this comment.
LGTM, tackle TODOs. I'll see if next/index.ts:477-482 is needed or if it's considered a hosting bug. Add changelog.
leoortizz
commented
Feb 26, 2024
src/frameworks/next/constants.ts
Outdated
|
|
||
| export const ESBUILD_VERSION = "0.19.2"; | ||
|
|
||
| // TODO: import from next/constants after bumping Next.js dependency |
jamesdaniels
approved these changes
Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6653
Scenarios Tested
Sample Commands