Redmine

Since markup help already has information about tables (#12734), I am changing the subject of this issue.

The attached patch adds a button to insert a table into the wiki toolbar.
The button create a table with rows / columns according to the selected range.

Markdown:

|A |B |C |D |E |
|--|--|--|--|--|
|  |  |  |  |  |
|  |  |  |  |  |
|  |  |  |  |  |

Textile:

|_.A|_.B|_.C|_.D|_.E|
|  |  |  |  |  |
|  |  |  |  |  |
|  |  |  |  |  |

Currently no icon image is set for the button. It is necessary to create a new appropriate icon image.

I made a new icon image.

Hiroyuki ENDO wrote:

I made a new icon image.

Thank you for making the icon.
The icon looks very nice!

Screenshot when image.png is applied:

Updated the patch to use image.png as table button icon.

Fixed a patch.

Unfortunately the grid lines of the selection UI are not properly displayed in Firefox.

Chrome:

Firefox:

This seems to be a long running bug of Firefox though: https://bugzilla.mozilla.org/show_bug.cgi?id=688556

There seem to be workarounds, like using

background-clip: padding-box;

Kevin Fischer wrote:

Unfortunately the grid lines of the selection UI are not properly displayed in Firefox.

Thanks for sharing the information!!
Operation verification on browsers other than Chrome was insufficient.
Since a problem was found not only in Firefox but also in IE11, a patch that solves the problem is attached.

0002-Firefox-support.patch resolves Firefox by removing `td { position: relative; }`.
0003-IE11-support.patch avoids using repeat function that did not work in IE11.

Setting the target version to 4.2.0.

Jan from Planio www.plan.io wrote:

For the icon, I think famfamfam should be used to stay consistent with the style of other icons in Redmine.

Thank you for the feedback. I think the suggested table icon is better than famfamfam's table icon because famfamfam's table icon looks like a document.

The suggested icon:

famfamfam's table icon:

Committed the patch. Thank you for improving Redmine.