-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FindZLIB.cmake doesn't find the zlib-ng debug build on Mac #1793
Comments
That seems like it might also be a problem for madler/zlib correct? Btw, I'm not seeing that statement in our CMakeLists.txt. |
The so-called standard |
See line 564: |
I see, so then it seems we do match behavior of madler/zlib. |
I can't see any special handling for Mac in stock zlib's CMakeLists.txt, so this is bug in CMake, not zlib or zlib-ng. |
Ah indeed, you seem to be right. |
For non-Windows systems, finding debug build is unsupported in module mode, it should still work in config mode though, but that is kinda untested and still unsupported as there is no "default" location for debug libraries and the config mode hasn't been supported long enough yet... |
In the zlib-ng root CMakeLists.txt file the CMAKE_DEBUG_POSTFIX variable is set to "d".
This results for debug builds in a library name with a "d" suffix, e.g., zlibstaticd.lib.
However, this only happens for Windows (due to the "if (MSVC)" statement in the CMakeLists.txt file).
The standard FindZLIB.cmake file expects this suffix also for Mac, which is not the case currently.
As a result, when using find_package(ZLIB) a system library is found instead of our custom build zlib-ng library.
The text was updated successfully, but these errors were encountered: