-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Imported Target ZLIB::ZLIB
for CMake.
#1320
Comments
ZLIB::ZLIB
target alias (to follow FindZLIB.cmake
convention).ZLIB::ZLIB
for CMake.
I have nothing against adding Only issue I can think of is that when we are building both static and shared version, which one does the alias point to... Do we use |
About that, I have some points to ask and discuss. Usually, the IMPORTED library target name is related to the package name. For example, the IMPORTED target name of Moreover, there are lots of downstream libraries using Therefore, I have some questions to ask the AUTHOR of this library:
By the way, Conan Package Manager already provides |
We can't rely on some third-party package manager to provide imported targets, as it is not guaranteed that everyone use same package manager. Exact spelling of the imported target is however open for discussion at this stage. |
It is related to the pull request of the old repository: madler/zlib#337
There are two features I agree to support:
ZLIB::ZLIB
target alias (to followFindZLIB.cmake
convention).The text was updated successfully, but these errors were encountered: