Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Frontend Migration]: Update API endpoint /api/playlist/ (POST, GET) add custom playlist handling #733

Open
MerlinScheurer opened this issue May 19, 2024 · 4 comments
Open

[Frontend Migration]: Update API endpoint /api/playlist/ (POST, GET) add custom playlist handling #733

MerlinScheurer opened this issue May 19, 2024 · 4 comments
Labels
backend react migration Tracking our new React based frontend

Comments

@MerlinScheurer
Copy link
Collaborator

MerlinScheurer commented May 19, 2024 •
edited
Loading

Domain

Backend

Description

Is your feature request related to a problem? Please describe.

The endpoint /api/playlist/ is missing handling for custom playlists, resulting in 500 server error.

Describe the solution you'd like

The endpoint handles the create statement in the POST body as the request to create a custom playlist.
And the endpoint GET takes custom playlist sorting into account.

Additional context

/api/playlist/ ( POST, GET )

Request body:

{ "data": { "create": "playlist-id" } }

Possibly implemented in a module way as described in #721
@MerlinScheurer MerlinScheurer added the react migration Tracking our new React based frontend label May 19, 2024
@MerlinScheurer MerlinScheurer changed the title [Frontend Migration]: Update API endpoint /api/playlist/ (POST) add custom playlist handling [Frontend Migration]: Update API endpoint /api/playlist/ (POST, GET) add custom playlist handling May 23, 2024
@ralphv
Copy link

ralphv commented May 28, 2024

I have this issue, but not through the API, latest version v0.4.8 I can't add custom playlist from UI. I get 500 server error

@MerlinScheurer
Copy link
Collaborator Author

It is not related, since this is a request to add an api endpoint and yours is a bug report.
@ralphv can you please create a new bug report for your issue?

@bbilly1
Copy link
Member

bbilly1 commented May 28, 2024

Custom Playlist are only implemented through the form at the moment. Api implementation will happen later with the refactor, as documented in this issue.

@ralphv
Copy link

ralphv commented May 28, 2024

It is not related, since this is a request to add an api endpoint and yours is a bug report. @ralphv can you please create a new bug report for your issue?

Sure thing, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend react migration Tracking our new React based frontend
Projects
Frontend Migration
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MerlinScheurer @ralphv @bbilly1