Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Channel-specific auto-delete setting not used if greater than global setting #673

Open
2 tasks done
jonvmey opened this issue Mar 7, 2024 · 1 comment
Open
2 tasks done
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jonvmey
Copy link

jonvmey commented Mar 7, 2024

I've read the documentation

Operating System

Debian 11

Your Bug Report

Describe the bug

Channel-specific overrides for auto-deleting watched videos don't get applied properly if the global auto-delete time is shorter than the channel-specific time.

Steps To Reproduce

Set the global auto-delete watched videos time to X days, then set a channel-specific auto-delete override to Y day, with X < Y. Mark some videos on that channel as watched. Those videos will be deleted after X days.

Expected behavior

Videos for channels with an override set should be ignored by the global auto-delete settings and only be deleted after the channel-specific number of days.

Relevant log output

N/A

Anything else?

Looking at the auto-delete code this is occurring because auto_delete_all doesn't do any filtering for channel-specific settings when querying which videos to delete. The reverse scenario of global auto-delete being longer works fine because the channel-specific delete will still occur at the expected time.

On a related note it doesn't appear to be possible to have global auto-delete enabled and then disable auto-delete for specific channels. Setting the channel-specific value to 0 just disables the channel-specific setting making it fall back to the global setting. I know the same effect could be achieved by disabling global auto-delete and just setting it on every channel I want auto-delete on. In my setup I want auto-delete on almost every channel so manually setting this gets rather tedious. If possible this would be nice to have, I can open a separate feature request for this though if you'd like. It's somewhat similar to #486 but at a channel level I suppose.

@bbilly1
Copy link
Member

bbilly1 commented Mar 16, 2024

I see how this could happen. Looks like you have a good grasp on things. Please look into it.

@bbilly1 bbilly1 added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants