-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Missing Menu metadata #488
Comments
We don't necessarily reproduce all the cli behavior of yt-dlp. Does yt-dlp python API have an option for chapters? At quick glance I couldn't find anything related to chapters. The cli seems to handle that differently:
If you find a way to access that from the info json, even better, then we can index it and also add it to the player. Please help with that. |
Happy to help with this. It seems like the chapters are indeed included as part of the info json. E.g. the command [
{
"start_time": 0,
"title": "01.Deathro - E.S.S.O. (ft. RRThiel)",
"end_time": 256
},
{
"start_time": 256,
"title": "02.Tony Thai - Ghost Town Funk",
"end_time": 465
},
{
"start_time": 465,
"title": "03.nu11 - The Tower Of Dreams",
"end_time": 782
},
{
"start_time": 782,
"title": "04.Karl Brueggemann - Moon Factory Zone",
"end_time": 934
},
{
"start_time": 934,
"title": "05.Rei8bit - Utilize The Individuality",
"end_time": 1137
},
{
"start_time": 1137,
"title": "06.scythe - いつか笑い話",
"end_time": 1335
},
{
"start_time": 1335,
"title": "07.tom_atom - Run To Avoid Being Late",
"end_time": 1542
},
{
"start_time": 1542,
"title": "08.Wool Pool - Souvenir Selection",
"end_time": 1699
},
{
"start_time": 1699,
"title": "09.EX-LYD - Sunken City",
"end_time": 1946
},
{
"start_time": 1946,
"title": "10.Maak - No Rain No Rainbow",
"end_time": 2207
},
{
"start_time": 2207,
"title": "11.iDoge - Red Sun",
"end_time": 2428
},
{
"start_time": 2428,
"title": "12.SymphonicGames - Fire Run",
"end_time": 2594
},
{
"start_time": 2594,
"title": "13.kgb525 - Facing Armored Windsor",
"end_time": 2744
},
{
"start_time": 2744,
"title": "14.FearOfDark - Comfy Cutie Hangout Zone",
"end_time": 2969
}
] Additionally, I in order to reproduce the import yt_dlp
def download_video(url):
ydl_opts = {
"format": "mp4",
"postprocessors": [{
"add_chapters": True,
"add_infojson": "if_exists",
"add_metadata": True,
"key": "FFmpegMetadata",
}]
}
with yt_dlp.YoutubeDL(ydl_opts) as ydl:
ydl.download([url])
video_url = "https://www.youtube.com/watch?v=ixTlSrViaFc"
download_video(video_url) Running |
Looks like we have most of that already included here: https://github.com/tubearchivist/tubearchivist/blob/f848e73251d59de75671aeb97e08f064601a6042/tubearchivist/home/src/download/yt_dlp_handler.py#L293C10-L300 If you remove the |
I've read the documentation
Operating System
Debian 10 buster Kernel 4.19
Your Bug Report
Describe the bug
When downloading a video with chapters, chapter metadata is not included in the file
Steps To Reproduce
mediainfo
output with a file donwloaded usingyt-dlp -f mp4 --embed-metadata
Expected behavior
The metadata should match that of
yt-dlp
Relevant log output
Given the following video: https://www.youtube.com/watch?v=ixTlSrViaFc
Downloading it with latest TubeArchivist (with the
Current metadata embed setting: True
)Mediainfo output:
whereas downloading with
yt-dlp -f mp4 --embed-metadata URL
givesMediainfo output:
The text was updated successfully, but these errors were encountered: