Make the code resilient against an empty recipient.

petergoldstein · petergoldstein · commit 67a78e49115e · 2016-02-12T07:36:07.000-08:00
diff --git a/lib/griddler/email.rb b/lib/griddler/email.rb
@@ -37,7 +37,9 @@ def config
     end
 
     def recipients(type)
-      params[type].to_a.map { |recipient| extract_address(recipient) }
+      params[type].to_a.reject(&:empty?).map do |recipient|
+        extract_address(recipient)
+      end
     end
 
     def extract_address(address)
diff --git a/spec/griddler/email_spec.rb b/spec/griddler/email_spec.rb
@@ -783,4 +783,19 @@ def header_from_email(header)
       expect(email.to.map { |to| to[:full] }).to eq recipients
     end
   end
+
+  context 'with an empty recipient in to field' do
+    it 'includes all of the emails' do
+      recipients =
+        ['caleb@example.com',
+         '',
+         '<joel@example.com>',
+         'Swift <swift@example.com>']
+      params = { to: recipients, from: 'ralph@example.com', text: 'hi guys' }
+
+      email = Griddler::Email.new(params)
+
+      expect(email.to.map { |to| to[:full] }).to eq recipients.reject(&:empty?)
+    end
+  end
 end
