Skip to content

feature(envs) - re-implement envs extends feature #9257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GiladShoham merged 36 commits into from
Dec 15, 2024
Merged

feature(envs) - re-implement envs extends feature #9257

GiladShoham merged 36 commits into from
Dec 15, 2024

Conversation

@GiladShoham
Copy link
Member

@GiladShoham GiladShoham commented Oct 21, 2024 •
edited
Loading

Proposed Changes

  • Change extends in env.jsonc to accept env component id instead of package name
  • Store resolved env jsonc in the models
  • Read parents env jsonc from model if not exist in the workspace
  • Fix many envs<>components loading order issues

GiladShoham and others added 30 commits October 21, 2024 14:25
@GiladShoham
feature(envs) - re-implement envs extends feature
c2390e4
@GiladShoham
fix tests
bac214e
@GiladShoham
add e2e tests for env jsonc extends
cd30e08
@GiladShoham
add more env jsonc extends tests
fa404a8
@GiladShoham
env jsonc detector
9065cbb
@GiladShoham
run load slot when resolving parent env manifest
6301a02
@davidfirst
refactor, populate consumerComponent.overrides later in the process
e0ef102
@GiladShoham
Merge branch 'move-overrides-set' of https://github.com/teambit/bit i…
6574966 
…nto envs-extends
@GiladShoham
fix env.jsonc extends version resolution
b81c570
@GiladShoham
types
3dd0200
@GiladShoham
handling snap from scope
902aaec
@GiladShoham
Merge branch 'master' into envs-extends
e059b2b
@GiladShoham
linting
a7cbd70
@GiladShoham
linting
304b496
@GiladShoham
types
1113ef5
@GiladShoham
fixes
26b3b7a
@GiladShoham
improve workspace.resolveComponentIdFromPackageName
3efdf4f
@GiladShoham
fixes
b979b4b
@GiladShoham
improve tests
d105214
@GiladShoham
remove only
c944a0b
@GiladShoham
fixes
f43eeba
@GiladShoham
linting
5d2d9e0
@GiladShoham
Merge branch 'master' into envs-extends
555d21c
@GiladShoham
Merge branch 'master' into envs-extends
0c9c0bd
@GiladShoham
Merge branch 'master' into envs-extends
006b4b2
@GiladShoham
Merge branch 'master' into envs-extends
eb0b0fa
@GiladShoham
Merge branch 'master' into envs-extends
c8c19b7 
# Conflicts:
#	components/legacy/consumer-component/consumer-component.ts
#	components/legacy/consumer-component/dependencies/dependencies.ts
#	components/legacy/consumer-config/component-overrides.ts
#	scopes/dependencies/dependencies/dependencies-loader/apply-overrides.ts
#	scopes/dependencies/dependency-resolver/dependency-resolver.main.runtime.ts
@GiladShoham
fixes
683f2be
@GiladShoham
linting
6157257
@GiladShoham
fix config
20cbe0d
@GiladShoham GiladShoham marked this pull request as ready for review December 15, 2024 15:59
@GiladShoham GiladShoham merged commit dba4813 into master Dec 15, 2024
10 checks passed
@GiladShoham GiladShoham deleted the envs-extends branch December 15, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guysaar223 guysaar223 guysaar223 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GiladShoham @guysaar223 @davidfirst