Tests for inflator failure. #8582
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Fischiii a big thanks for doing this. |
|
OK, thanks for the repro. See Fischiii#1 that you can merge into your PR. But
Context takeover discussed here https://websockets.readthedocs.io/en/stable/topics/compression.html#compression-parameters Final block discussed here https://datatracker.ietf.org/doc/html/rfc7692#section-7.2.1 @swankjesse do you remember the algorithm here? |
Fix/inflator failure
|
@yschimke merged |
|
I think I’ve isolated this? |
|
@swankjesse since the spec specifically has additional padding data, are we sure it's not just a difference between the spec padding and what our vanilla compression expects? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8551
Added tests to reproduce the issue.
Added one test with the broken deflated message:
"inflater left with deflated bytes"
Added another test with a similar, but working message:
"inflater left with deflated bytes working message"
The first test results in the exact same behaviour as we see within okhttp when we discovered the issue: #8551