WIP adding CodeGenerator.group #984
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RBusarow
force-pushed
the
rick/CodeGenerator_group
branch
4 times, most recently
from
39d357e to
a720e2f
Compare
The `group` value allows for basic scheduling of code generators. All code generators with the same group will be executed in a loop together until no new code is generated.
RBusarow
force-pushed
the
rick/CodeGenerator_group
branch
from
a720e2f to
b120e17
Compare
jingibus
reviewed
Jul 15, 2024
| * The default [group][CodeGenerator.group] for code generators. | ||
| * A lower group value will be executed before any higher group value. | ||
| */ | ||
| public const val GROUP_DEFAULT: Int = 0 |
There was a problem hiding this comment.
Could use an enum for this, too! Integers for priority levels tend to lose information fairly readily. An enum would retain ordering guarantees, but enforce naming and make it a lot easier to nav through and find out where a particular CodeGenerator sits in the group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.