Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to limit Dagger factory generation to specific source sets #727

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
+64 −2
Open

Option to limit Dagger factory generation to specific source sets #727

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c391610
Add generateFactoriesPathWhitelist parameter to compiler
matejdro Jul 21, 2023
e86512a
Add path filtering to dagger factory generators
matejdro Jul 21, 2023
db0bec6
Add generateDaggerFactoriesSourceSetWhitelist property to Gradle plugin
matejdro Jul 21, 2023
c6d46c2
Document generateDaggerFactoriesSourceSetWhitelist
matejdro Jul 21, 2023
49e49e7
Revert compiler changes
matejdro Jul 31, 2023
086f51c
Control Dagger factory whitelist directly from plugin
matejdro Jul 31, 2023
7eefeb9
Change whitelist to allowlist
matejdro Jul 31, 2023
07a342a
Merge branch 'main' into dagger-factories-source-sets
matejdro Jul 31, 2023
7ec16b2
Merge branch 'main' into dagger-factories-source-sets
matejdro Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Control Dagger factory whitelist directly from plugin
  • Loading branch information
@matejdro
matejdro committed Jul 31, 2023
commit 086f51c714f9416430acc07fb0d5d0b05384fd93
25 changes: 16 additions & 9 deletions gradle-plugin/src/main/java/com/squareup/anvil/plugin/AnvilPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,14 +155,23 @@ internal open class AnvilPlugin : KotlinCompilerPluginSupportPlugin {
}
}

val variantWhitelist = variant.variantFilter.generateDaggerFactoriesSourceSetWhitelist.flatMap {sourceSetName ->
val whitelistedVariants = variant.variantFilter
.generateDaggerFactoriesSourceSetWhitelist.map { sourceSetName ->
val sourceSet = variant.kotlinSourceSets.singleOrNull { it.name == sourceSetName }
?: throw GradleException("Unknown variant $sourceSetName. Available variants: " +
"${variant.kotlinSourceSets.joinToString { it.name }}")
"${variant.kotlinSourceSets.joinToString { it.name }}"
)

sourceSet.kotlin.srcDirs
sourceSet
}

val enableDaggerFactoriesInThisVariant = whitelistedVariants.isEmpty() ||
variant.androidSourceSets?.any { androidSourceSet ->
whitelistedVariants.any { whitelistedSourceSet ->
whitelistedSourceSet.name == androidSourceSet.name
}
} == true

return project.provider {
listOf(
FilesSubpluginOption(
Expand All @@ -171,15 +180,13 @@ internal open class AnvilPlugin : KotlinCompilerPluginSupportPlugin {
),
SubpluginOption(
key = "generate-dagger-factories",
lazy { variant.variantFilter.generateDaggerFactories.toString() }
),
SubpluginOption(
key = "generate-dagger-factories-path-whitelist",
lazy { variantWhitelist.joinToString(":") { it.absolutePath } }
lazy { (variant.variantFilter.generateDaggerFactories &&
enableDaggerFactoriesInThisVariant).toString() }
),
SubpluginOption(
key = "generate-dagger-factories-only",
lazy { variant.variantFilter.generateDaggerFactoriesOnly.toString() }
lazy { (variant.variantFilter.generateDaggerFactoriesOnly &&
enableDaggerFactoriesInThisVariant).toString() }
),
SubpluginOption(
key = "disable-component-merging",
Expand Down