Option to limit Dagger factory generation to specific source sets #727
Conversation
matejdro
changed the title
There was a problem hiding this comment.
Three high level comments
- Absolute paths are likely to cause gradle caching issues as they cannot be cached across machines or even different repo installations
- With KSP, this doesn't become possible I think?
- Instead of whitelist/blacklist, prefer allowlist/blocklist as both more descriptive names and more inclusive naming.
|
Huh you are right about build cache, I totally forgot about that. I just noticed that there is a FilesSubpluginOption (which is already used for build dir argument, that I totally missed). I think switching to that should resolve this issue? To be honest, I have no idea how KSP works, so I'm not sure if it would work or not. Does KSP not give us a list of files to work with? I can change the PR to allowlist/blocklist, if desired. |
# Conflicts: # gradle-plugin/src/main/java/com/squareup/anvil/plugin/AnvilPlugin.kt
|
Doh, I have managed to find much simpler solution that does not even touch the compiler and thus sidestepping the absolute path issue entirely (possibly also sidesteps KSP problem?). I have also renamed all whitelist references to allowlist. |
# Conflicts: # gradle-plugin/src/main/java/com/squareup/anvil/plugin/VariantFilter.kt
@ZacSweers Are you able to provide more details on this? Is it related to us no longer manually managing the output dir/location? |
Fixes #718
PR adds extra command line argument to the compiler that receives whitelist of absolute paths within which factory generation can occur. Then gradle plugin generates list of those paths from list of source sets that user specified.PR now checks every set of Kotlin compiler run against user's allowlist of source sets. If source set is not allowed, it disables factory generation for this run.