Skip to content

[BUG] SQL Driver does nothing with column 'enabled'  #1225

Open
@eelco2k

Description

@eelco2k

sql-app-manager.ts does nothing with the column 'enabled' as stated in the documentation to create an apps table for app authentication

https://github.com/soketi/soketi/blob/5d188786beaf683aca2115a6247dcdc15c29ac77/src/app-managers/sql-app-manager.ts#L79C15-L79C25
and

protected selectByKey(key: string): Promise<App[]> {

just do a where clause on the id or key.

Maybe just an idea as enhancement: allow somewhere to create extra query filters. for example whereIsNull('deleted_at') if your table has this 'deleted_at' timestamp column.

Or at least give an example in the docs how to create a custom sql driver / manager.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions