ENH Implement inverse_transform in DictionaryLearning, SparseCoder and MiniBatchDictionaryLearning
#30443
+36
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rflamary
changed the title
inverse_transform in DictionaryLearningand SparseCoderinverse_transform in DictionaryLearningand SparseCoder
agramfort
requested changes
Dec 9, 2024
| def _inverse_transform(self, code, dictionary): | ||
| """Private method allowing to accommodate both DictionaryLearning and | ||
| SparseCoder.""" | ||
| if self.split_sign: |
There was a problem hiding this comment.
@rflamary can you just see what test needs to be updated to have these lines covered? thanks
There was a problem hiding this comment.
It is done (slight modification of the test checking that split_sign works). Now all tests pass
rflamary
changed the title
inverse_transform in DictionaryLearningand SparseCoderinverse_transform in DictionaryLearning, SparseCoder and MiniBatchDictionaryLearning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #30442
Ping to @agramfort
What does this implement/fix? Explain your changes.
This PR implements the methods in the class
_BaseSparseCodingfrom https://github.com/scikit-learn/scikit-learn/blob/main/sklearn/decomposition/_dict_learning.pyThe tests have also been updated to check that the reconstruction is accurate.
Any other comments?