FIX gaussian mixture diagonal covariance must result from float64 operands #30383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rands Squaring float32 numbers leads to a significant loss of precision the regularization term reg_covar might not mitigate. Moreover, as avgX_means is equal to avg_means2, the returned expression can be simplified
…ian covariance calculation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squaring float32 numbers leads to a significant loss of precision the regularization term reg_covar might not mitigate.
Moreover, as avgX_means is equal to avg_means2, the returned expression can be simplified.
Reference Issues/PRs
Fixes #30382
What does this implement/fix? Explain your changes.
This commit sums the input array with an array of zeros (implicit np.float64 conversion on 64-bit platforms) before squaring it in-place. Overall, it does not require more memory than the former implementation,
_estimate_gaussian_covariances_diag being further optimized as computing avg_X_means is not needed.