ci: use dorny/paths-filter to filter paths when running go-tests
#3675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GenPage I defer this one to you since you have done considerable amount of work on the workflows |
|
As the original writer of #3123 of the negative tests, as (previously) recommended by github docs, FWIW, I'm completely OK with removing the negative tests which are finicky and tricky to debug. This proposed method of using a separate action to do the path filtering will reduce maintenance and make it easier to troubleshoot the triggered action. |
GenPage
approved these changes
Sep 7, 2023
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a proposal / discussion starter
what
Instead of having 2 separate workflow files, one that runs tests based on changed paths and the other runs on other changed files, have only one workflow that makes sure to either run tests or no tests.
why
concurrencylock, whoever wins executes.on.*.paths, there is no way to ensuretest-required.ymlis only run iftest.ymlis skipped (i.e. always give priority totest.yml)Examples of when
test.ymlfailed to run while there are changed go files:test.ymlskippedtest-required.ymltaking overtests
I tested in ghaiszaher#51
drawbacks
(I still see it better than risking skipping tests when they are actually failing)
alternatives
references