Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node-resolve): set development or production condition #1823

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(node-resolve): set development or production condition #1823

wants to merge 1 commit into from
+35 −4

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Dec 2, 2024 •
edited
Loading

Rollup Plugin Name: @rollup/plugin-node-resolve

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes - while hopefully no one is relying on having development code in their production bundle, it's a breaking change strictly speaking
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

closes #1819

Description

Ensure that development or production is always set in conditions

@benmccann benmccann requested a review from tjenkinson as a code owner December 2, 2024 19:28
@benmccann benmccann force-pushed the dev-prod-condition branch 2 times, most recently from 5fd201c to 4854b71 Compare December 2, 2024 21:06
@benmccann
feat(node-resolve): set development or production condition
e7bbc57 
The `'development'` or `'production'` condition will be set. If neither the `'development'` or `'production'` conditions are provided it will default to `production` - or `development` if `NODE_ENV` is set to a value other than `production`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjenkinson tjenkinson Awaiting requested review from tjenkinson tjenkinson is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Always include either development or production in exportConditions
1 participant
@benmccann