Skip to content

docs / metrics view locale_d3 example #6149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nishantmonu51 merged 2 commits into from
Dec 6, 2024
Merged

docs / metrics view locale_d3 example #6149

nishantmonu51 merged 2 commits into from
Dec 6, 2024

Conversation

@royendo
Copy link
Contributor

@royendo royendo commented Nov 25, 2024 •
edited
Loading

Not sure if necessary but based on Dhiraj showcase, might need some examples, we link the website but would be nice to able to reference one example via rill docs

    format_d3: "$,"
    format_d3_locale: 
      grouping: [3, 2]
      currency: ["₹", ""]

@royendo royendo changed the title Will add a few examples to format_d3_loacle docs / metrics view locale_d3 example Nov 25, 2024
@royendo royendo added the Type:Documentation Improvements or additions to documentation label Dec 4, 2024
@royendo royendo marked this pull request as ready for review December 4, 2024 18:03
nishantmonu51
nishantmonu51 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@nishantmonu51 nishantmonu51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nishantmonu51 nishantmonu51 merged commit 4623c95 into main Dec 6, 2024
5 checks passed
@nishantmonu51 nishantmonu51 deleted the docs/format-d3-locale branch December 6, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nishantmonu51 nishantmonu51 nishantmonu51 approved these changes

Assignees

No one assigned

Labels

Type:Documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@royendo @nishantmonu51