Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rnd bit generation in rmat_rectangular_kernel #2524

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Fix rnd bit generation in rmat_rectangular_kernel #2524

merged 1 commit into from
Dec 11, 2024

Conversation

tfeher
Copy link
Contributor

@tfeher tfeher commented Dec 9, 2024

For certain architectures, the compiler always generates zero destination bit in the following loop

raft/cpp/include/raft/random/detail/rmat_rectangular_generator.cuh

Lines 160 to 162 in ee45ce7

for (; i < c_scale; ++i) {
gen_and_update_bits(src_id, dst_id, a + c, ProbT(1), ProbT(1), r_scale, c_scale, i, gen);
}
irrespective of the random value that shall determine which bit to use for dst_id.

This PR refactors the loop. This way the dst_id number has the desired random distribution for all bits.

@tfeher tfeher requested a review from a team as a code owner December 9, 2024 17:19
@github-actions github-actions bot added the cpp label Dec 9, 2024
@tfeher tfeher added bug Something isn't working non-breaking Non-breaking change and removed cpp labels Dec 9, 2024
@tfeher tfeher self-assigned this Dec 9, 2024
@tfeher
Copy link
Contributor Author

tfeher commented Dec 9, 2024

LinewiseOp test goes OOM, restarted the test.

[----------] 9 tests from LinewiseOp/TenGigs_float_uint64_t
[ RUN      ] LinewiseOp/TenGigs_float_uint64_t.run/0
unknown file: Failure
C++ exception with description "std::bad_alloc: out_of_memory: CUDA error at: /opt/conda/envs/test/include/rmm/mr/device/cuda_memory_resource.hpp:62: cudaErrorMemoryAllocation out of memory" thrown in the test body.
[  FAILED  ] LinewiseOp/TenGigs_float_uint64_t.run/0, where GetParam() = (0, 0) (32 ms

@robertmaynard robertmaynard self-assigned this Dec 10, 2024
@cjnolet
Copy link
Member

cjnolet commented Dec 11, 2024

/merge

@rapids-bot rapids-bot bot merged commit 1e5030d into rapidsai:branch-25.02 Dec 11, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees

@robertmaynard robertmaynard

@tfeher tfeher

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tfeher @cjnolet @robertmaynard