Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage dangling lines and tie lines #172

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

rolnico
Copy link
Member

@rolnico rolnico commented Sep 26, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Feature

What is the current behavior?
Tie lines are not managed and dangling lines are badly managed

What is the new behavior (if this is a feature change)?
Tie lines are managed like lines
Unpaired dangling lines are managed as line + load + generation. Note that the generation part (if present) is only added to the load part.

TieLines and DanglingLines can be used in contingencies and sections' branchList. Note that there is today a limitation in powsybl-core contingency DSL loader lacking support of TieLineContingency, will be resolved in powsybl/powsybl-core#3213

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@rolnico rolnico requested review from marifunf and olperr1 September 26, 2024 07:59
@rolnico rolnico self-assigned this Sep 26, 2024

This comment was marked as outdated.

@rolnico rolnico marked this pull request as ready for review September 27, 2024 07:20

This comment was marked as outdated.

@jeandemanged
Copy link
Member

Thanks
However, shouldn't unpaired DanglingLine model all this:

  • the "half-line" part
  • the load part
  • the optional generation part
    ?

@rolnico
Copy link
Member Author

rolnico commented Nov 7, 2024

Thanks However, shouldn't unpaired DanglingLine model all this:

* the "half-line" part

* the load part

* the optional generation part
  ?

Probably, yes!
I'll have to look at how to model this

Base automatically changed from nro/use_different_connectables to main November 8, 2024 13:46
# Conflicts:
#	metrix-integration/src/main/java/com/powsybl/metrix/integration/MetrixNetwork.java
#	metrix-integration/src/main/java/com/powsybl/metrix/integration/dataGenerator/MetrixInputData.java
#	metrix-integration/src/test/java/com/powsybl/metrix/integration/MetrixNetworkTest.java
@jeandemanged jeandemanged changed the title Manage dangling lines and tie lines [WIP] Manage dangling lines and tie lines Nov 8, 2024
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Copy link

sonarcloud bot commented Nov 15, 2024

Copy link

sonarcloud bot commented Nov 15, 2024

@jeandemanged jeandemanged changed the title [WIP] Manage dangling lines and tie lines Manage dangling lines and tie lines Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants