Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenDroneMap #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add OpenDroneMap #37

wants to merge 1 commit into from

Conversation

wzel
Copy link
Contributor

@wzel wzel commented Jan 31, 2020

No description provided.

@pmoulon
Copy link
Member

pmoulon commented Jan 31, 2020

OpenDrone map is a toolchain, not really a SFM system by itself.
See here: https://github.com/OpenDroneMap/ODM/tree/master/SuperBuild/cmake They are using OpenSFM.

So if we want add it I would consider it under system and explicit write this is a toolchain.

@wzel
Copy link
Contributor Author

wzel commented Feb 1, 2020

And OpenSFM uses OpenCV, as far as I'm aware. It's hard to draw a boundary in my feeling.

By "under system" you mean "a subsystem", right? Maybe it would make sense to add a "dependency" column to the table indicating whether the software offers an original implementation or exploits existing one available in another project.

@pmoulon
Copy link
Member

pmoulon commented Feb 1, 2020

OpenSfM depends on many libraries but they have developed their own SfM chain (https://www.opensfm.org/docs/building.html#install-dependencies). OpenCV is used to manipulate images, and OpenGV is used for model estimation, but their implemented their own SfM pipeline (https://www.opensfm.org/docs/reconstruction_module.html).

I would classify OpenDroneMap as a toolchain/subsystem - using existing pipelines rather implementing SfM algorithm.

As you said it is hard to draw a boundary line, that's why I have added only library that implement a complete system that is reliable enough to perform large scale reconstruction (100+ to 1000+ images). OpenCV SfM toolchain has not been really used by the community and that's why I did not include it here. Does it make sense (Proven SfM project)?

@wzel
Copy link
Contributor Author

wzel commented Feb 3, 2020

For OpenDroneMap, I guess the controversy stems from the different ways one can read the "OpenSource SfM" header. You interpret it narrowly, which is fine, and I'm interpreting it broadly. How about renaming "OpenSource resources", above, to "OpenSource algorithm implementations" (or something like that) to make your interpretation more explicit?

With OpenCV, I'm less convinced. I don't think that popularity should be a factor. That said, I'm not going to pursue this issue further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants