Skip to content

Expose Aws::Http::HttpResponse object in the callback of HttpRequestor Gem  #2118

Open
@baothientran

Description

@baothientran

Is your feature request related to a problem? Please describe.

Currently HttpRequestManager only send the response's body to the callback. However, our use case requires to know the response's ContentType to parse the body correctly, or its headers for the internal http cache. It would be helpful if the Http manager exposes Aws::Http::HttpResponse object which already stores all those information through a callback, similar to the current Callback or TextCallback in the Http Parameter and TextParameter respectively. But I'm not sure if there are any implications for the proposed change though.

Describe the solution you'd like

Would that be possible to implement another AddRequest*() member function family in the HttpRequestorRequests class with the callback accepting Aws::Http::HttpResponse as its parameter? If we agree with the solution, I can definitely help to implement it and submit the PR back

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature/cloud-serviceThis item is related to the cloud services.good-first-issueIssue ready for a new contributor according to the help wanted guidelines.help-wantedIssue that needs help from a contributor. Must meet help wanted guidelines.kind/enhancementEnhancement to an existing feature.priority/majorIssue causes friction in workflows, but can be worked around or avoided. Rare or difficult crashes.sig/networkCategorizes an issue or PR as relevant to SIG Network.triage/acceptedIndicates an issue or PR is ready to be actively worked on.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions