Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

24.09 Release - AWSNativeSDK 1.11.288-rev2-ios contain _CCCryptor* private Apple APIs #18514

Open
Twolewis opened this issue Nov 27, 2024 · 2 comments
Open

24.09 Release - AWSNativeSDK 1.11.288-rev2-ios contain _CCCryptor* private Apple APIs #18514

Twolewis opened this issue Nov 27, 2024 · 2 comments
Assignees
@Ulrick28
Labels
kind/bug-2409 Used for stabilization/24.09 issues priority/critical Critical priority. Must be actively worked on as someone's top priority right now. sig/network Categorizes an issue or PR as relevant to SIG Network.

Comments

@Twolewis
Copy link
Contributor

Bug Description

The AWSNativeSDK 1.11.288 rev2 iOS 3rd Party package contains the following private Apple APIs, causing build submissions to fail:

_CCCryptorGCMAddAAD
_CCCryptorGCMAddIV
_CCCryptorGCMFinal

The following message is generated during submission:

ITMS-90338: Non-public API usage - The app references non-public symbols in MadWorld.GameLauncher: _CCCryptorGCMAddAAD, _CCCryptorGCMAddIV, _CCCryptorGCMFinal. If method names in your source code match the private Apple APIs listed above, altering your method names will help prevent this app from being flagged in future submissions. In addition, note that one or more of the above APIs may be located in a static library that was included with your app. If so, they must be removed.

Assets-Required

None

Steps to Reproduce

  • Download the AWSNativeSDK-1.11.299-rev2-ios package
  • Enter the AWSNativeSDK/lib/Release directory in terminal
  • Execute: "nm -a libaws-c-cal.a | grep Crypto"

Expected Behavior

The private Apple APIs should not be found

Actual Behavior

$ nm -a libaws-c-cal.a | grep Crypto
U _CCCryptorCreateWithMode
U _CCCryptorFinal
U _CCCryptorGCMAddAAD
U _CCCryptorGCMFinalize
U _CCCryptorGCMSetIV
U _CCCryptorRelease
U _CCCryptorUpdate

Screenshots/Videos

None

Found In Branch

Tag: 2409.1

Commit ID From

5bb3ec5

Desktop/Device

Mac, iOS Packages.

Additional Context

No response
@Twolewis Twolewis added kind/bug-2409 Used for stabilization/24.09 issues needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 27, 2024
@Twolewis
Copy link
Contributor Author

Note: Found this open PR that I believe resolves the issue:
#18098

@AMZN-Gene AMZN-Gene added sig/network Categorizes an issue or PR as relevant to SIG Network. priority/critical Critical priority. Must be actively worked on as someone's top priority right now. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 5, 2024
@AMZN-Gene
Copy link
Contributor

AMZN-Gene commented Dec 5, 2024 •
edited
Loading

Note: Found this open PR that I believe resolves the issue: #18098

Good find! Ooph. Looks like that PR was held up because Jenkins was failing random editor tests. It was created via bot, I'll try to rebuild with latest.

EDIT: Wait... this PR might also cause a crash on startup. Keeping Android AWS SDK back at 1.11.288 to avoid runtime crash on startup.
see aws/aws-sdk-cpp#3047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ulrick28 Ulrick28

Labels
kind/bug-2409 Used for stabilization/24.09 issues priority/critical Critical priority. Must be actively worked on as someone's top priority right now. sig/network Categorizes an issue or PR as relevant to SIG Network.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Twolewis @AMZN-Gene @Ulrick28