Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting a project in Project Manager does not remove the project tile #18452

Open
spham-amzn opened this issue Nov 8, 2024 · 1 comment
Open

Deleting a project in Project Manager does not remove the project tile #18452

spham-amzn opened this issue Nov 8, 2024 · 1 comment
Labels
good-first-issue Issue ready for a new contributor according to the help wanted guidelines. kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/content Categorizes an issue or PR as relevant to SIG Content.

Comments

@spham-amzn
Copy link
Contributor

spham-amzn commented Nov 8, 2024 •
edited
Loading

Describe the bug
In O3DE Project Manager, if there is only one project tile in the Projects page, deleting it will delete the project contents but does not remove the project tile. If there are multiple project tiles, deleting projects will remove them. This only occurs if there is only one project tile left and its the one that you want to delete.

Note that it will correct itself one a restart of the Project Manager, so exiting and re-launching it will fix it.

Steps to reproduce
Steps to reproduce the behavior:

  1. Make sure the environment is clean (no pre-existing O3DE projects or .o3de folder)
  2. Install O3DE SDK
  3. Launch O3DE (Project Manager)
  4. Create a new project (using any template)
  5. In the option menu for the new project, click on Delete Project

Expected behavior
The project is deleted from disk and the tile is removed from Project Manager

Actual behavior
The project is deleted from disk but the tile still remains in Project Manager

Screenshots/Video

Found in Branch
main (installer)

Commit ID from o3de/o3de Repository
c602b49

Desktop/Device (please complete the following information):

  • Device: PC
  • OS: Windows and Linux
  • Version 10 and 22.04
  • CPU N/A
  • GPU N/A
  • Memory N/A

Additional context
Add any other context about the problem here.
@spham-amzn spham-amzn added kind/bug Categorizes issue or PR as related to a bug. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. good-first-issue Issue ready for a new contributor according to the help wanted guidelines. sig/content Categorizes an issue or PR as relevant to SIG Content. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 8, 2024
This was referenced Nov 12, 2024
Closed
Merged
@devldm
Copy link
Contributor

devldm commented Nov 12, 2024

Hi, I'd happily look at solving this if i was assigned. I have a working PR (Currently in draft state), its a fairly simple solution that may need reworking if deemed too naive.

This would be my first contribution here.

I came across a few potential ways to fix this bug such as calling ResetScreenRequest(ProjectManagerScreen:Projects) in HandleRemoveProject() similar to HandleNewProjectButton() which worked but seemed like an not ideal solution and seemed to cause some visual bugs on manual testing.

It would also be possible / simple to pull RemoveProjectButtonsFromFlowLayout() out of the if(!projects.isEmpty() check and refactor it to handle "Empty" projects.

I've first focussed on the draft PR solution as it seemed like simplest solution to me. Happy to hear your thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Issue ready for a new contributor according to the help wanted guidelines. kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/content Categorizes an issue or PR as relevant to SIG Content.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@devldm @spham-amzn