enable miniupnpc wheel builds on windows #766
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like they are included when built here.
|
|
Ah, probably because of this hack that got copied over from the Chia builds of miniupnpc.
|
|
@miniupnp, do you expect the existing Windows wheels to work on their own without providing a separately built |
As far as I remember, the .dll is required ;) |
2 tasks
|
hum It is possible there is a confusion between libminiupnpc.a (static) and miniupnpc.lib + miniupnpc.dll |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently this is just for comparison. The existing uploaded wheels seem to be missing the actual dll.