Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete proposed changes #754

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Self-Hosting-Group
Copy link
Contributor

The following PRs/issues have not been fully adopted or parts have been overlooked. The following PR tries to fix this.

  • Complete: option enable_natpmp => enable_pcp_pmp 02da705
    Remove old name still present in documentation/comments
  • Complete: upnpc: Revise help/usage #681
    Fix partial help rewrite (remove "redirect", currently more confusing). Add note about optional IGDv2 commands and IPv4/IPv6. Minor wording update/normalise, reduce line width/breaks.
  • Complete: miniupnpd: SSDP search response cache-control header, no UPnP UDA 1.0 compliance #698
    Comment notify_interval in configuration, as same value as default and fix help.
  • Complete: miniupnpd: Add daemon version to XML (child) device descriptions #709
    Empty dummy values from advertised informal serialNumber and UPC as IMHO it looks unfinished/unclean not like a long existing project. Remove the change in the root device modelDescription to keep the root device white labelled as before.
  • Complete: Fix/standardise SOAP/HTTP headers #745
    Remove the Cache-Control: no-cache header as it is not used in the IGD specification and by other clients and test tool. Only used in HTTP when using a cache/proxy, which is not possible with IGD. Normally only used in HTTP for GET and not for POST, but in miniupnpc only for POST and not for GET requests. No routers known to need this.

@Self-Hosting-Group Self-Hosting-Group changed the title Complete proposed Complete proposed changes Jun 11, 2024
@miniupnp
Copy link
Owner

I think now it is almost OK.

Copy link

@Zidane115 Zidane115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zidane115
Copy link

Ef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants