-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete proposed changes #754
Open
Self-Hosting-Group
wants to merge
5
commits into
miniupnp:master
Choose a base branch
from
Self-Hosting-Group:complete-proposed
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Complete proposed changes #754
Self-Hosting-Group
wants to merge
5
commits into
miniupnp:master
from
Self-Hosting-Group:complete-proposed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Self-Hosting-Group
force-pushed
the
complete-proposed
branch
from
June 17, 2024 05:47
bed2cb4
to
368eef4
Compare
I think now it is almost OK. |
Zidane115
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ef |
changed in b4d7803 as miniupnp#780 was not applied correctly
Self-Hosting-Group
force-pushed
the
complete-proposed
branch
from
October 23, 2024 05:01
368eef4
to
ab2a129
Compare
Self-Hosting-Group
temporarily deployed
to
pypi
October 23, 2024 05:06 — with
GitHub Actions
Inactive
Self-Hosting-Group
force-pushed
the
complete-proposed
branch
from
October 23, 2024 05:41
0ae7ad2
to
ab2a129
Compare
Self-Hosting-Group
temporarily deployed
to
pypi
October 23, 2024 05:45 — with
GitHub Actions
Inactive
Self-Hosting-Group
force-pushed
the
complete-proposed
branch
from
October 23, 2024 05:49
ab2a129
to
40f4336
Compare
Self-Hosting-Group
temporarily deployed
to
pypi
October 23, 2024 05:54 — with
GitHub Actions
Inactive
Self-Hosting-Group
temporarily deployed
to
pypi
October 23, 2024 06:12 — with
GitHub Actions
Inactive
Self-Hosting-Group
force-pushed
the
complete-proposed
branch
from
October 23, 2024 06:14
62c9a3e
to
35d5549
Compare
Self-Hosting-Group
temporarily deployed
to
pypi
October 23, 2024 06:20 — with
GitHub Actions
Inactive
Zidane115
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PRs/issues have not been fully adopted or parts have been overlooked. The following PR tries to fix this.
Remove old name still present in documentation/comments
Fix partial help rewrite (remove "redirect", currently more confusing). Add note about optional IGDv2 commands and IPv4/IPv6. Minor wording update/normalise, reduce line width/breaks.
Comment
notify_interval
in configuration, as same value as default and fix help.Empty dummy values from advertised informal
serialNumber
andUPC
as IMHO it looks unfinished/unclean not like a long existing project. Remove the change in the root devicemodelDescription
to keep the root device white labelled as before.Remove the
Cache-Control: no-cache
header as it is not used in the IGD specification and by other clients and test tool. Only used in HTTP when using a cache/proxy, which is not possible with IGD. Normally only used in HTTP for GET and not for POST, but in miniupnpc only for POST and not for GET requests. No routers known to need this.