miniupnpd: Increase port map description length limit to 255 #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
miniupnpd was first developped for pf and use the pf rule "label" which is limited to 64 bytes to store the description. |
miniupnp
reviewed
Jun 4, 2024
Self-Hosting-Group
force-pushed
the
description-length
branch
2 times, most recently
from
07de68b to
3cb5571
Compare
|
In fact the limit should be removed from miniupnpc (API needs to be changed) |
Self-Hosting-Group
changed the title
Self-Hosting-Group
added a commit
to Self-Hosting-Group/miniupnp
that referenced
this pull request
Jan 9, 2025
Self-Hosting-Group
force-pushed
the
description-length
branch
from
3cb5571 to
e6e3feb
Compare
Self-Hosting-Group
force-pushed
the
description-length
branch
from
e6e3feb to
7d73ea8
Compare
Self-Hosting-Group
referenced
this pull request
Mar 3, 2025
The changes are minor, no client code should be using what's removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maximum length is not defined in the UPnP IGD standards. The built-in Windows client allows any description length (>20k tested). The PCP description option standard (not implemented) has a length limit of 1016. Other limits: iptables/nftables comments are limited to 256/128 (not used).