Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should connections be released when Whisper is closed? #4

Closed
mijorus opened this issue Feb 7, 2023 · 4 comments
Closed

Should connections be released when Whisper is closed? #4

mijorus opened this issue Feb 7, 2023 · 4 comments
Assignees
Labels
question Further information is requested

Comments

@mijorus
Copy link
Owner

mijorus commented Feb 7, 2023

Let me know what you think

@mijorus mijorus added the question Further information is requested label Feb 7, 2023
@mijorus mijorus pinned this issue Feb 7, 2023
@dusansimic
Copy link

I think so 😁. I was surprised that they are not released on app close. If the app is meant for checking whether microphone works and what it's recording by playing the input on a specified output, it would probably be expected that it stops doing that once closed.

@mijorus
Copy link
Owner Author

mijorus commented Feb 7, 2023

I originally designed it as a replacement for Helvum, that's why it does't do that.

@rene-coty
Copy link
Contributor

Maybe this should be an option in the preferences window.. I must admit I was also surprised that the app didn't automatically release connections when closed, but if it's intentional, then the possibility should still exist

@mijorus
Copy link
Owner Author

mijorus commented Feb 12, 2023

Maybe this should be an option in the preferences window.. I must admit I was also surprised that the app didn't automatically release connections when closed, but if it's intentional, then the possibility should still exist

This feature is coming in the next update

@mijorus mijorus self-assigned this Feb 13, 2023
@mijorus mijorus closed this as completed Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants