Replies: 1 comment 1 reply
-
|
Hi, I'll have to take a more careful look. That code's been that way forever and I don't know the rationale offhand. It's also difficult to change pre-existing counter behavior because it can set off people's alarms when numbers suddenly change. On the surface it does look like the GAT commands just emulate touch counters, I just don't know why or if that's correct or if it's the same in all of the protocols offhand. |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
I understand it needs careful approach. Thanks for your consideration anyway. |
Beta Was this translation helpful? Give feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi, we are using memcached quite extensively, but have found out just recently that using get and touch (GAT) command doesn't increment
get_hitsstats. Is this by design/convention?As an outsider I'd expect both counters to increment (
touch_hitsandget_hits) in that case.I've traced the issue to the source code
memcached/proto_bin.c
Line 497 in 77709d0
and propose changing
elsecondition toif (should_return_value).I understand there may be more considerations in place, it just struck me as an unintuitive approach.
Thanks, Tom
Beta Was this translation helpful? Give feedback.
All reactions