Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve, simplify tests #67

Open
falquaddoomi opened this issue Nov 20, 2024 · 0 comments
Open

Improve, simplify tests #67

falquaddoomi opened this issue Nov 20, 2024 · 0 comments
Assignees

Comments

@falquaddoomi
Copy link
Collaborator

As raised by @d33bs in #62 (comment) and #62 (comment), the tests have a few areas where they could be simplified or improved.

Some suggestions were:

  • adding type hints to test function parameters
  • removing commented-out lines, e.g. models in pytest.mark.parametrize calls, or at least explaining why they're commented out
  • avoiding aliasing the tmp_path variable as output_folder in tests.

I imagine that we'd have a PR that just addresses these kinds of changes without changing any other functionality, to ease verification that the tests are still correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant