Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Would it be better to change MGLXXX to EGLXXX? #83

Open
wxdut opened this issue Jun 23, 2022 · 1 comment
Open

Would it be better to change MGLXXX to EGLXXX? #83

wxdut opened this issue Jun 23, 2022 · 1 comment

Comments

@wxdut
Copy link

wxdut commented Jun 23, 2022 •
edited
Loading

Hi, Le Hoang Quyen, thank you so much for developing MetalANGLE.

I'm a iOS developer. I wonder why not change EGLKit class name from MGLXXX to EGLXXX? That is, keep the class name exactly the same as the library class name. So we don't have to modify the existing code, just replace the standard GLKit framework with MetalANGLE.

Thank you again. Looking forward to your reply!!
@wxdut wxdut changed the title Would it be better to change MGLXXX to EGLXXX Would it be better to change MGLXXX to EGLXXX? Jun 23, 2022
@kakashidinho
Copy link
Owner

kakashidinho commented Jun 27, 2022 •
edited
Loading

Do you mean why not using the same class prefix as Apple’s GLKit classes’ names? E.g EAGL?

well, it’s a bit complicated. Even if you don’t link against GLKit framework, Xcode still secretly link your app with it for unknown reasons, so it would cause naming conflicts.

Furthermore, the way a default framebuffer is created is not exactly the same between MGL and EAGL ones. Hence the former is not an exact drop-in replacement for the latter. Pls see https://github.com/kakashidinho/metalangle/blob/master/src/libANGLE/renderer/metal/DevSetup.md#porting-from-apples-eagl--glkit-to-mglkit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kakashidinho @wxdut