Merge pull request #219 from jeffshek/supplement-stack-views

jeffshek · web-flow · commit ac41cb5f17e3 · 2020-09-05T22:10:10.000-05:00
Add Supplement Stack Functionality to Log Views
diff --git a/open/core/betterself/serializers/supplement_log_serializers.py b/open/core/betterself/serializers/supplement_log_serializers.py
@@ -1,3 +1,4 @@
+from django.core.exceptions import ObjectDoesNotExist
 from rest_framework.exceptions import ValidationError
 from rest_framework.fields import (
     UUIDField,
@@ -11,6 +12,7 @@
 from open.core.betterself.constants import INPUT_SOURCES_TUPLES, WEB_INPUT_SOURCE
 from open.core.betterself.models.supplement import Supplement
 from open.core.betterself.models.supplement_log import SupplementLog
+from open.core.betterself.models.supplement_stack import SupplementStack
 from open.core.betterself.serializers.mixins import (
     BaseCreateUpdateSerializer,
     BaseModelReadSerializer,
@@ -61,7 +63,10 @@ class SupplementLogCreateUpdateSerializer(BaseCreateUpdateSerializer):
     user = HiddenField(default=CurrentUserDefault())
     uuid = UUIDField(required=False, read_only=True)
     notes = CharField(
-        default="", trim_whitespace=True, required=False, allow_blank=True,
+        default="",
+        trim_whitespace=True,
+        required=False,
+        allow_blank=True,
     )
     quantity = DecimalField(decimal_places=4, max_digits=10, default=1)
     source = ChoiceField(INPUT_SOURCES_TUPLES, default=WEB_INPUT_SOURCE)
@@ -81,24 +86,84 @@ class Meta:
 
     def validate_supplement_uuid(self, value):
         user = self.context["request"].user
-        validate_model_uuid(Supplement, uuid=value, user=user)
+        try:
+            validate_model_uuid(Supplement, uuid=value, user=user)
+        except ValidationError:
+            # we allow for supplement_stack_uuid to also be passed in here, a bit of a hack
+            validate_model_uuid(SupplementStack, uuid=value, user=user)
+
         return value
 
     def validate(self, validated_data):
+        """
+        This code isn't pretty, but it's because i'm jamming supplement stack and supplements in one view
+        """
         user = self.context["request"].user
         is_creating_instance = not self.instance
 
         if validated_data.get("supplement"):
-            supplement_uuid = validated_data["supplement"]["uuid"]
-            supplement = Supplement.objects.get(uuid=supplement_uuid, user=user)
-            validated_data["supplement"] = supplement
+            supplement = validated_data.pop("supplement")
+            supplement_uuid = supplement["uuid"]
+
+            try:
+                supplement = Supplement.objects.get(uuid=supplement_uuid, user=user)
+                validated_data["supplement"] = supplement
+
+            except ObjectDoesNotExist:
+                # don't allow supplement stacks if it's not a create operation
+                if not is_creating_instance:
+                    raise
+
+                # if it doesn't exist, it's a supplement stack
+                stack = SupplementStack.objects.get(uuid=supplement_uuid, user=user)
+                validated_data["stack"] = stack
 
-        if is_creating_instance:
+        if is_creating_instance and validated_data.get("supplement"):
             if self.Meta.model.objects.filter(
-                user=user, supplement=supplement, time=validated_data["time"],
+                user=user,
+                supplement=supplement,
+                time=validated_data["time"],
             ).exists():
                 raise ValidationError(
-                    f"Fields user, supplement, and time are not unique!"
+                    "Fields user, supplement, and time are not unique!"
                 )
+        elif is_creating_instance and validated_data.get("stack"):
+            stack = validated_data["stack"]
+            stack_supplements = [item.supplement for item in stack.compositions.all()]
+
+            for supplement in stack_supplements:
+                if self.Meta.model.objects.filter(
+                    user=user,
+                    supplement=supplement,
+                    time=validated_data["time"],
+                ).exists():
+                    raise ValidationError(
+                        "Fields user, supplement, and time are not unique!"
+                    )
 
         return validated_data
+
+    def create(self, validated_data):
+        if validated_data.get("supplement"):
+            # normal drf serializers, change nothing
+            return super().create(validated_data)
+
+        elif validated_data.get("stack"):
+            stack = validated_data.pop("stack")
+            stack_compositions = stack.compositions.all()
+
+            created_instances = []
+            for composition in stack_compositions:
+                results = validated_data.copy()
+                supplement = composition.supplement
+
+                # a stack might have a quantity of 2 of something
+                updated_quantity = results["quantity"] * composition.quantity
+
+                results["supplement"] = supplement
+                results["quantity"] = updated_quantity
+
+                created_instance = self.Meta.model.objects.create(**results)
+                created_instances.append(created_instance)
+
+            return created_instances
diff --git a/open/core/betterself/tests/views/test_supplement_log_views.py b/open/core/betterself/tests/views/test_supplement_log_views.py
@@ -9,6 +9,8 @@
 from open.core.betterself.factories import (
     SupplementLogFactory,
     SupplementFactory,
+    SupplementStackFactory,
+    SupplementStackCompositionFactory,
 )
 from open.core.betterself.models.supplement_log import SupplementLog
 from open.core.betterself.tests.mixins.resource_mixin import (
@@ -148,6 +150,42 @@ def test_display_name_on_log_serializer_some_days_ago(self):
         display_name = response.data["display_name"]
         self.assertTrue("8.5 days ago" in display_name, display_name)
 
+    def test_create_supplement_log_with_supplement_stack(self):
+        """
+        dpy test open.core.betterself.tests.views.test_supplement_log_views.TestSupplementLogViews.test_create_supplement_log_with_supplement_stack --keepdb
+        """
+        # a hidden feature, not really restful, but allow a user to send a supplement_stack_uuid
+        # to create a set of supplements taken at the same time
+
+        supplements = SupplementFactory.create_batch(3, user=self.user_1)
+
+        stack = SupplementStackFactory(user=self.user_1)
+
+        compositions = []
+        for supplement in supplements:
+            composition = SupplementStackCompositionFactory(
+                user=self.user_1, supplement=supplement, stack=stack, quantity=2
+            )
+            compositions.append(composition)
+
+        stack_uuid = stack.uuid
+
+        utc_now = get_utc_now()
+        post_data = {
+            "supplement_uuid": str(stack_uuid),
+            "time": utc_now.isoformat(),
+            "quantity": 5,
+        }
+
+        response = self.client_1.post(self.url, data=post_data)
+        self.assertEqual(response.status_code, 200, response.data)
+
+        for supplement in supplements:
+            matching_log = SupplementLog.objects.get(
+                supplement=supplement, quantity=10, user=self.user_1, time=utc_now
+            )
+            self.assertIsNotNone(matching_log)
+
 
 class TestSupplementLogGetUpdateDelete(
     BetterSelfResourceViewTestCaseMixin, TestCase, GetTestsMixin, DeleteTestsMixin
diff --git a/open/core/betterself/views/supplement_log_views.py b/open/core/betterself/views/supplement_log_views.py
@@ -1,5 +1,7 @@
 import logging
 
+from rest_framework.response import Response
+
 from open.core.betterself.models.supplement_log import SupplementLog
 from open.core.betterself.serializers.supplement_log_serializers import (
     SupplementLogReadSerializer,
@@ -18,6 +20,23 @@ class SupplementLogCreateListView(BaseCreateListView):
     read_serializer_class = SupplementLogReadSerializer
     create_serializer_class = SupplementLogCreateUpdateSerializer
 
+    def post(self, request):
+        context = {"request": request}
+        serializer = self.create_serializer_class(data=request.data, context=context)
+
+        serializer.is_valid(raise_exception=True)
+
+        # normal operation, proceed as normal
+        if "supplement" in serializer.validated_data:
+            instance = serializer.save()
+            serialized_data = self.read_serializer_class(instance).data
+        else:
+            # supplement_stack - do some non-elegant stuff
+            instances = serializer.save()
+            serialized_data = self.read_serializer_class(instances, many=True).data
+
+        return Response(serialized_data)
+
 
 class SupplementLogGetUpdateView(BaseGetUpdateDeleteView):
     model_class = SupplementLog
