Skip to content
This repository has been archived by the owner on Oct 4, 2020. It is now read-only.

Empty file with single empty line throws an "expected final newline" error #156

Open
robinmanuelthiel opened this issue Mar 11, 2019 · 1 comment
Open

Empty file with single empty line throws an "expected final newline" error #156

robinmanuelthiel opened this issue Mar 11, 2019 · 1 comment

Comments

@robinmanuelthiel
Copy link

Empty files in the project, which do have just one single empty line (as shown below) throw errors when insert_final_newline = true is set in the .editorconfig.

image

eclint check

#> src/app/components/about/about.component.scss
#       01:01 ❌ expected final newline

Is that an expected behaviour? I would argue, that this file does end with an empty line. Even if it's the only line it has.
@JoaRiski
Copy link

JoaRiski commented Dec 1, 2019

This also happens with completely empty files, which is a bit silly

@ppalaga ppalaga mentioned this issue Dec 18, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robinmanuelthiel @JoaRiski