Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements for the discrete PT1 and PT2 blocks in 'filters_lib' #45

Open
jwithelm opened this issue Feb 7, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@jwithelm
Copy link
Contributor

jwithelm commented Feb 7, 2024

All of the following suggestions would be breaking changes, meaning that any library or model using these blocks would need to be revised. The proposed changes are not important and could be made if another important breaking change were made.

  • Rename block: 'PT1 discrete with saturations' -> 'PT1 discrete with saturation'
  • Rename mask parameter names for discrete PT1 and PT2:
    • initial output parameter names are not consistent, they are e. g. y_0_src and x_init. It would probably be better to name them y_0_src and y_0.
    • the naming of output min/max parameters and initial output parameters should also be consistent?
  • Change the PT2 block, so that omega and d can be set separately to 'internal / external' .
@jwithelm jwithelm added the enhancement New feature or request label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant