Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: drop support for Python 2.7 #778

Merged
merged 21 commits into from
Aug 3, 2021
Merged

fix!: drop support for Python 2.7 #778

merged 21 commits into from
Aug 3, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 16, 2021

  • Drop use of six wrapper library.
  • Use editable installs for tests.
  • Drop use of u" prefixes.

Release-As: 2.0.0b1

Closes #777.

@tseaver tseaver requested a review from a team as a code owner June 16, 2021 16:07
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 16, 2021
@parthea
Copy link
Contributor

parthea commented Jun 16, 2021

I'm planning to use suffix -rc1 when major version >= 1 . Could we do the same here or are you also planning to also use rcX after bX? In other words, would the versioning be:

2.0.0rc1
2.0.0rc2

or

2.0.0b1
2.0.0b2
followed by
2.0.0rc1
2.0.0rc2

@tseaver
Copy link
Contributor Author

tseaver commented Jun 16, 2021

@parthea I wasn't planning to use rc for the intial Py3-only release -- we need to have some shakeout time for the dependent libraries, which makes this more of a beta than a release candidate. Update: to me, RC implies that we assume all is well, and will release effectively unchanged unless something unexpected happens. For this release, I'm actually half expecting that we will uncover some other issue, e.g. needing to supply some extra backward-compat support.

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2021
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2021
@tseaver
Copy link
Contributor Author

tseaver commented Jun 18, 2021

I'm having difficulty reproducing the Kokoro systest failures. The failing sessions:

  • default_explicit_authorized_user
  • default_explicit_authorized_user_explicit_project
  • default_explicit_authorized_user_async
  • default_explicit_authorized_user_explicit_project_async

all pass for me when run locally:

$ nox -f system_tests/noxfile.py -e default_explicit_authorized_user default_explicit_authorized_user_explicit_project default_explicit_authorized_user_async default_explicit_authorized_user_explicit_project_async
...
nox > Ran multiple sessions:
nox > * default_explicit_authorized_user-3.7: success
nox > * default_explicit_authorized_user_explicit_project-3.7: success
nox > * default_explicit_authorized_user_async-3.7: success
nox > * default_explicit_authorized_user_explicit_project_async-3.7: success

@busunkim96, @arithmetic1728, @crwilcox can any of you see what is happening?

@arithmetic1728
Copy link
Contributor

It seems the refresh token used in kokoro system test is expired.

google.auth.exceptions.RefreshError: ('invalid_grant: Token has been expired or revoked.', {'error': 'invalid_grant', 'error_description': 'Token has been expired or revoked.'})

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 14, 2021
@tseaver tseaver added the semver: major Hint for users that this is an API breaking change. label Jul 14, 2021
@tseaver tseaver requested a review from silvolu as a code owner July 23, 2021 20:43
@tseaver tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 3, 2021
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let @arithmetic1728 also take a look.

google/auth/version.py Outdated Show resolved Hide resolved
Copy link
Contributor

@arithmetic1728 arithmetic1728 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tseaver tseaver merged commit 560cf1e into master Aug 3, 2021
@tseaver tseaver deleted the 777-drop-python-2.7 branch August 3, 2021 20:35
This was referenced Aug 3, 2021
busunkim96 pushed a commit that referenced this pull request Aug 17, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [2.0.0](https://www.github.com/googleapis/google-auth-library-python/compare/v2.0.0-b1...v2.0.0) (2021-08-16)

### ⚠ BREAKING CHANGES
* drop support for Python 2.7 ([#778](https://www.github.com/googleapis/google-auth-library-python/issues/778)) ([560cf1e](https://www.github.com/googleapis/google-auth-library-python/commit/560cf1ed02a900436c5d9e0a0fb3f94b5fd98c55))

### Features

* service account is able to use a private token endpoint ([#835](https://www.github.com/googleapis/google-auth-library-python/issues/835)) ([20b817a](https://www.github.com/googleapis/google-auth-library-python/commit/20b817af8e202b0331998e5abde4e2a5aab51f9a))


### Bug Fixes

* downscoping documentation bugs ([#830](https://www.github.com/googleapis/google-auth-library-python/issues/830)) ([da8bb13](https://www.github.com/googleapis/google-auth-library-python/commit/da8bb13c1349e771ffc2e125256030495c53d956))
* Fix missing space in error message. ([#821](https://www.github.com/googleapis/google-auth-library-python/issues/821)) ([7b03988](https://www.github.com/googleapis/google-auth-library-python/commit/7b039888aeb6ec7691d91c9afce182b17f02b1a6))


### Documentation

* update user guide/references for downscoped creds ([#827](https://www.github.com/googleapis/google-auth-library-python/issues/827)) ([d1840dc](https://www.github.com/googleapis/google-auth-library-python/commit/d1840dcdcd03dfd7fdfa81d08da68402f6f8b658))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@clundin25 clundin25 mentioned this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. semver: major Hint for users that this is an API breaking change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Python 2.7 support
5 participants