Skip to content

fix: support custom alg in jwt header for signing #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arithmetic1728 merged 2 commits into from
Apr 8, 2021
Merged

fix: support custom alg in jwt header for signing #729

arithmetic1728 merged 2 commits into from
Apr 8, 2021

Conversation

@arithmetic1728
Copy link
Contributor

@arithmetic1728 arithmetic1728 commented Apr 8, 2021

Fix #725, use the alg in header if provided.

@arithmetic1728 arithmetic1728 requested a review from a team as a code owner April 8, 2021 00:06
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 8, 2021
@arithmetic1728 arithmetic1728 merged commit 0a83706 into master Apr 8, 2021
@arithmetic1728 arithmetic1728 deleted the signer branch April 8, 2021 17:58
@hiranya911 hiranya911 mentioned this pull request Apr 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

jwt.encode() overrides the algorithm specified by the caller

2 participants

@arithmetic1728 @busunkim96