Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs type #650

Closed
skelliest opened this issue Dec 4, 2020 · 1 comment · Fixed by #651
Closed

docs type #650

skelliest opened this issue Dec 4, 2020 · 1 comment · Fixed by #651
Assignees
@yoshi-automation
Labels
type: docs Improvement to the documentation for an API.

Comments

@skelliest
Copy link

google-auth-library-python/google/auth/impersonated_credentials.py

Line 151 in 41599ae

from google.oauth2 import service_acccount

Example has extra c and should read from google.oauth2 import service_account
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Dec 5, 2020
@busunkim96 busunkim96 added type: docs Improvement to the documentation for an API. and removed triage me I really want to be triaged. labels Dec 7, 2020
busunkim96 added a commit that referenced this issue Dec 7, 2020
@busunkim96
docs: fix typo in import
c2dfa05 
`service_acccount` -> `service_account`.

Closes #650
@busunkim96 busunkim96 mentioned this issue Dec 7, 2020
Merged
@busunkim96
Copy link
Contributor

@skelliest Thanks for catching that! I've opened #651 to fix the docs.

gcf-merge-on-green bot pushed a commit that referenced this issue Dec 7, 2020
@busunkim96
docs: fix typo in import (#651)
3319ea8 
`service_acccount` -> `service_account`.

Closes #650
gcf-merge-on-green bot pushed a commit that referenced this issue Dec 11, 2020
@release-please
chore: release 1.24.0 (#656)
647290a 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.24.0](https://www.github.com/googleapis/google-auth-library-python/compare/v1.23.0...v1.24.0) (2020-12-11)


### Features

* add Python 3.9 support, drop Python 3.5 support ([#655](https://www.github.com/googleapis/google-auth-library-python/issues/655)) ([6de753d](https://www.github.com/googleapis/google-auth-library-python/commit/6de753d585254c813b3e6cbde27bf5466261ba10)), closes [#654](https://www.github.com/googleapis/google-auth-library-python/issues/654)


### Bug Fixes

* avoid losing the original '_include_email' parameter in impersonated credentials ([#626](https://www.github.com/googleapis/google-auth-library-python/issues/626)) ([fd9b5b1](https://www.github.com/googleapis/google-auth-library-python/commit/fd9b5b10c80950784bd37ee56e32c505acb5078d))


### Documentation

* fix typo in import ([#651](https://www.github.com/googleapis/google-auth-library-python/issues/651)) ([3319ea8](https://www.github.com/googleapis/google-auth-library-python/commit/3319ea8ae876c73a94f51237b3bbb3f5df2aef89)), closes [#650](https://www.github.com/googleapis/google-auth-library-python/issues/650)
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoshi-automation yoshi-automation

Labels
type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: fix typo in import googleapis/google-auth-library-python
3 participants
@busunkim96 @skelliest @yoshi-automation