Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't add empty quota project #560

Merged
merged 2 commits into from
Jul 15, 2020
Merged

fix: don't add empty quota project #560

merged 2 commits into from
Jul 15, 2020

Conversation

busunkim96
Copy link
Contributor

Closes #559

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 15, 2020
@busunkim96 busunkim96 merged commit ab2be5d into master Jul 15, 2020
@tseaver tseaver deleted the no-empty-quota-proj branch October 28, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arithmetic1728 arithmetic1728 arithmetic1728 approved these changes

@software-dov software-dov Awaiting requested review from software-dov

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_default always sets credentials.quota_project_id to None
2 participants
@busunkim96 @arithmetic1728