Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check 'iss' in verify_oauth2_token #500

Merged
merged 7 commits into from
Jun 29, 2020
Merged

feat: check 'iss' in verify_oauth2_token #500

merged 7 commits into from
Jun 29, 2020

Conversation

busunkim96
Copy link
Contributor

Closes #499.

The value of iss in the ID token is equal to accounts.google.com or https://accounts.google.com.

The iss is already checked in other languages. See https://developers.google.com/identity/sign-in/web/backend-auth#using-a-google-api-client-library

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 6, 2020
@anguillanneuf anguillanneuf self-requested a review May 6, 2020 20:10
@kevinthecheung kevinthecheung mentioned this pull request May 6, 2020
Closed
@anguillanneuf anguillanneuf removed their request for review May 26, 2020 20:13
@anguillanneuf
Copy link
Contributor

anguillanneuf commented Jun 26, 2020 •
edited
Loading

@busunkim96 How to increase coverage in jwt.py line 294-5 and 296-7?

.nox/cover/lib/python3.7/site-packages/google/auth/jwt.py                            209      2     46      2    98%   294->295, 295, 296->297, 297
Command coverage report --show-missing --fail-under=100 failed with exit code 2
Session cover failed.

Oops I thought I was commenting on #502

@anguillanneuf
Copy link
Contributor

@busunkim96 Oh I just saw you opened a similar PR here too.

@anguillanneuf anguillanneuf merged commit c05b8b5 into master Jun 29, 2020
@anguillanneuf anguillanneuf deleted the id-token-iss-check branch June 29, 2020 23:27
@anguillanneuf anguillanneuf mentioned this pull request Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make verify_oauth2_token check the issuer claim
3 participants
@busunkim96 @anguillanneuf @googlebot